postgres.git / summary / log / commit / refs

commit    4ad846445dd0a1596ca7bfeb5b2ea93f6d7a751d
Author:   Noah Misch <noah@leadboat.com>
Date:     Tue Sep 16 16:40:44 2025 +0000
First released in: 13.23, 14.20, 15.15, 16.11, 17.7, 18.0

    Fix pg_dump COMMENT dependency for separate domain constraints.
    
    The COMMENT should depend on the separately-dumped constraint, not the
    domain.  Sufficient restore parallelism might fail the COMMENT command
    by issuing it before the constraint exists.  Back-patch to v13, like
    commit 0858f0f96ebb891c8960994f023ed5a17b758a38.
    
    Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
    Discussion: https://postgr.es/m/20250913020233.fa.nmisch@google.com
    Backpatch-through: 13


 src/bin/pg_dump/pg_dump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 764628e2e3c..dd7d5b514f3 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -18634,7 +18634,7 @@ dumpConstraint(Archive *fout, const ConstraintInfo *coninfo)
 				dumpComment(fout, conprefix->data, qtypname,
 							tyinfo->dobj.namespace->dobj.name,
 							tyinfo->rolname,
-							coninfo->dobj.catId, 0, tyinfo->dobj.dumpId);
+							coninfo->dobj.catId, 0, coninfo->dobj.dumpId);
 				destroyPQExpBuffer(conprefix);
 				free(qtypname);
 			}


[parent: dad1e259dfa9]