postgres.git / summary / log / commit / refs
commit 4c0ffe6244f2f487d89e132831ba34769aa018ed
Author: John Naylor <john.naylor@postgresql.org>
Date: Tue Mar 24 09:40:33 2026 +0000
First released in: 14.23, 15.18, 16.14, 17.10, 18.4
Fix copy-paste error in test_ginpostinglist
The check for a mismatch on the second decoded item pointer
was an exact copy of the first item pointer check, comparing
orig_itemptrs[0] with decoded_itemptrs[0] instead of orig_itemptrs[1]
with decoded_itemptrs[1]. The error message also reported (0, 1) as
the expected value instead of (blk, off). As a result, any decoding
error in the second item pointer (where the varbyte delta encoding
is exercised) would go undetected.
This has been wrong since commit bde7493d1, so backpatch to all
supported versions.
Author: Jianghua Yang <yjhjstz@gmail.com>
Discussion: https://postgr.es/m/CAAZLFmSOD8R7tZjRLZsmpKtJLoqjgawAaM-Pne1j8B_Q2aQK8w@mail.gmail.com
Backpatch-through: 14
src/test/modules/test_ginpostinglist/test_ginpostinglist.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/modules/test_ginpostinglist/test_ginpostinglist.c b/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
index 80cee656841..06271a1a45a 100644
--- a/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
+++ b/src/test/modules/test_ginpostinglist/test_ginpostinglist.c
@@ -72,12 +72,12 @@ test_itemptr_pair(BlockNumber blk, OffsetNumber off, int maxsize)
ItemPointerGetOffsetNumber(&decoded_itemptrs[0]));
if (ndecoded == 2 &&
- !ItemPointerEquals(&orig_itemptrs[0], &decoded_itemptrs[0]))
+ !ItemPointerEquals(&orig_itemptrs[1], &decoded_itemptrs[1]))
{
elog(ERROR, "mismatch on second itemptr: (%u, %d) vs (%u, %d)",
- 0, 1,
- ItemPointerGetBlockNumber(&decoded_itemptrs[0]),
- ItemPointerGetOffsetNumber(&decoded_itemptrs[0]));
+ blk, off,
+ ItemPointerGetBlockNumber(&decoded_itemptrs[1]),
+ ItemPointerGetOffsetNumber(&decoded_itemptrs[1]));
}
}
[parent: 77dff5d937b1]