postgres.git / summary / log / commit / refs

commit    4c64b51dc51f8ff7e3e51eebfe8d10469a577df1
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Mon Jul 12 08:13:33 2021 +0000

    Remove dead assignment to local variable.
    
    This should have been removed in commit 7e30c186da, which split the loop
    into two. Only the first loop uses the 'from' variable; updating it in
    the second loop is bogus. It was never read after the first loop, so this
    was harmless and surely optimized away by the compiler, but let's be tidy.
    
    Backpatch to all supported versions.
    
    Author: Ranier Vilela
    Discussion: https://www.postgresql.org/message-id/CAEudQAoWq%2BAL3BnELHu7gms2GN07k-np6yLbukGaxJ1vY-zeiQ%40mail.gmail.com


 src/backend/access/nbtree/nbtxlog.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/access/nbtree/nbtxlog.c b/src/backend/access/nbtree/nbtxlog.c
index c2e920f159c..786c08c0cea 100644
--- a/src/backend/access/nbtree/nbtxlog.c
+++ b/src/backend/access/nbtree/nbtxlog.c
@@ -77,7 +77,6 @@ _bt_restore_page(Page page, char *from, int len)
 		if (PageAddItem(page, items[i], itemsizes[i], nitems - i,
 						false, false) == InvalidOffsetNumber)
 			elog(PANIC, "_bt_restore_page: cannot add item to page");
-		from += itemsz;
 	}
 }
 


[parent: 2c9b46c090e7]