postgrespro.git / summary / log / commit / refs

commit    4cae471d1b6bec7493dcb2ca156382bef738f293
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Wed Apr 10 23:02:21 2019 +0000

    Fix backwards test in operator_precedence_warning logic.
    
    Warnings about unary minus might have been wrong.  It's a bit
    surprising that nobody noticed yet ... probably the precedence-warning
    feature hasn't really been used much in the field.
    
    Rikard Falkeborn
    
    Discussion: https://postgr.es/m/CADRDgG6fzA8A2oeygUw4=o7ywo4kvz26NxCSgpq22nMD73Bx4Q@mail.gmail.com


 src/backend/parser/parse_expr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/parser/parse_expr.c b/src/backend/parser/parse_expr.c
index 20d923203f..8e136a7981 100644
--- a/src/backend/parser/parse_expr.c
+++ b/src/backend/parser/parse_expr.c
@@ -3236,7 +3236,7 @@ operator_precedence_group(Node *node, const char **nodename)
 				*nodename = strVal(linitial(aexpr->name));
 				/* Ignore if op was always higher priority than IS-tests */
 				if (strcmp(*nodename, "+") == 0 ||
-					strcmp(*nodename, "-"))
+					strcmp(*nodename, "-") == 0)
 					group = 0;
 				else
 					group = PREC_GROUP_PREFIX_OP;


[parent: 765525c8c2c6]