postgres.git / summary / log / commit / refs

commit    4d33a7f2e714848ca7b5b7ef8e244eead078ca13
Author:   Peter Eisentraut <peter_e@gmx.net>
Date:     Tue Mar 28 13:00:59 2017 +0000

    Fix Perl code which had broken the Windows build
    
    The previous change wanted to avoid modifying $_ in grep, but the code
    just made the change in a local variable and then lost it.  Rewrite the
    code using a separate map and grep, which is clearer anyway.
    
    Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>


 src/tools/msvc/vcregress.pl | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
index d9367f8fd5a..8933920d9bf 100644
--- a/src/tools/msvc/vcregress.pl
+++ b/src/tools/msvc/vcregress.pl
@@ -520,11 +520,9 @@ sub fetchRegressOpts
 		# Substitute known Makefile variables, then ignore options that retain
 		# an unhandled variable reference.  Ignore anything that isn't an
 		# option starting with "--".
-		@opts = grep {
-			my $x = $_;
-			$x =~ s/\Q$(top_builddir)\E/\"$topdir\"/;
-			$x !~ /\$\(/ && $x =~ /^--/
-		} split(/\s+/, $1);
+		@opts = grep { !/\$\(/ && /^--/ }
+		  map { (my $x = $_) =~ s/\Q$(top_builddir)\E/\"$topdir\"/; $x; }
+		  split(/\s+/, $1);
 	}
 	if ($m =~ /^\s*ENCODING\s*=\s*(\S+)/m)
 	{


[parent: a6f22e83562d]