postgrespro.git / summary / log / commit / refs

commit    4fbf809e13c3ba09c4f03d148cb58767e56f67f1
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Wed May 22 14:38:21 2019 +0000

    In transam.h, don't expose static inline functions to frontend code.
    
    That leads to unsatisfied external references if the C compiler fails
    to elide unused static functions.  Apparently, we have no buildfarm
    members building HEAD that have that issue ... but such compilers still
    exist in the wild.  Need to do something about that.
    
    In passing, fix Berkeley-era typo in comment.
    
    Discussion: https://postgr.es/m/27054.1558533367@sss.pgh.pa.us


 src/include/access/transam.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/include/access/transam.h b/src/include/access/transam.h
index 7966a9e90b..4e08c4b865 100644
--- a/src/include/access/transam.h
+++ b/src/include/access/transam.h
@@ -231,6 +231,13 @@ extern void AdvanceOldestClogXid(TransactionId oldest_datfrozenxid);
 extern bool ForceTransactionIdLimitUpdate(void);
 extern Oid	GetNewObjectId(void);
 
+/*
+ * Some frontend programs include this header.  For compilers that emit static
+ * inline functions even when they're unused, that leads to unsatisfied
+ * external references; hence hide them with #ifndef FRONTEND.
+ */
+#ifndef FRONTEND
+
 /*
  * For callers that just need the XID part of the next transaction ID.
  */
@@ -240,4 +247,6 @@ ReadNewTransactionId(void)
 	return XidFromFullTransactionId(ReadNextFullTransactionId());
 }
 
-#endif							/* TRAMSAM_H */
+#endif							/* FRONTEND */
+
+#endif							/* TRANSAM_H */


[parent: b8c6014a65ee]