postgres.git / summary / log / commit / refs

commit    58af84f4bba5c87b352cf40e276e287fd289bd77
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Thu Dec 11 22:37:17 2014 +0000
First released in: 9.5.0

    Fix completely broken REINDEX SCHEMA testcase.
    
    Aside from not testing the case it claimed to test (namely a permissions
    failure), it left a login-capable role lying around, which quite aside
    from possibly being a security hole would cause subsequent regression runs
    to fail since the role would already exist.


 src/test/regress/expected/create_index.out | 9 ++++-----
 src/test/regress/sql/create_index.sql      | 6 +++---
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/src/test/regress/expected/create_index.out b/src/test/regress/expected/create_index.out
index eba14e262f2..06c67162971 100644
--- a/src/test/regress/expected/create_index.out
+++ b/src/test/regress/expected/create_index.out
@@ -2846,14 +2846,13 @@ REINDEX SCHEMA schema_to_reindex; -- failure, cannot run in a transaction
 ERROR:  REINDEX SCHEMA cannot run inside a transaction block
 END;
 -- Failure for unauthorized user
-CREATE ROLE reindexuser login;
-SET SESSION ROLE user_reindex;
-ERROR:  role "user_reindex" does not exist
+CREATE ROLE regression_reindexuser NOLOGIN;
+SET SESSION ROLE regression_reindexuser;
 REINDEX SCHEMA schema_to_reindex;
+ERROR:  must be owner of schema schema_to_reindex
 -- Clean up
 RESET ROLE;
-DROP ROLE user_reindex;
-ERROR:  role "user_reindex" does not exist
+DROP ROLE regression_reindexuser;
 DROP SCHEMA schema_to_reindex CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DETAIL:  drop cascades to table schema_to_reindex.table1
diff --git a/src/test/regress/sql/create_index.sql b/src/test/regress/sql/create_index.sql
index 1cd57dada78..fdda078c3a8 100644
--- a/src/test/regress/sql/create_index.sql
+++ b/src/test/regress/sql/create_index.sql
@@ -979,11 +979,11 @@ REINDEX SCHEMA schema_to_reindex; -- failure, cannot run in a transaction
 END;
 
 -- Failure for unauthorized user
-CREATE ROLE reindexuser login;
-SET SESSION ROLE user_reindex;
+CREATE ROLE regression_reindexuser NOLOGIN;
+SET SESSION ROLE regression_reindexuser;
 REINDEX SCHEMA schema_to_reindex;
 
 -- Clean up
 RESET ROLE;
-DROP ROLE user_reindex;
+DROP ROLE regression_reindexuser;
 DROP SCHEMA schema_to_reindex CASCADE;


[parent: 06d5803ffa1e]