postgres.git / summary / log / commit / refs

commit    59aeb693f67fc15dfa58e2fdada2a70ce1004660
Author:   Álvaro Herrera <alvherre@kurilemu.de>
Date:     Fri Oct 31 16:43:15 2025 +0000
First released in: 17.7, 18.1

    pg_createsubscriber: Fix error complaining about the wrong thing
    
    The code updates the system identifier, then runs pg_walreset; if the
    latter fails, it complains about the former, which makes no sense.
    Change the error message to complain about the right thing.
    
    Noticed while reviewing a patch touching nearby code.
    
    Author: Álvaro Herrera <alvherre@kurilemu.de>
    Backpatch-through: 17


src/bin/pg_basebackup/pg_createsubscriber.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c index 1d0fe44b6d3..6f77b283784 100644 --- a/src/bin/pg_basebackup/pg_createsubscriber.c +++ b/src/bin/pg_basebackup/pg_createsubscriber.c @@ -697,9 +697,9 @@ modify_subscriber_sysid(const struct CreateSubscriberOptions *opt) int rc = system(cmd_str); if (rc == 0) - pg_log_info("subscriber successfully changed the system identifier"); + pg_log_info("subscriber successfully reset WAL on the subscriber"); else - pg_fatal("could not change system identifier of subscriber: %s", wait_result_to_str(rc)); + pg_fatal("could not reset WAL on subscriber: %s", wait_result_to_str(rc)); } pg_free(cf); [parent: 094118805693]