postgres.git / summary / log / commit / refs

commit    59c2f7efaef665d1d3c47a4d3b72cf39bd03cffb
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sun Feb 08 01:05:52 2026 +0000
First released in: 16.12, 17.8, 18.2

    meson: host_system value for Solaris is 'sunos' not 'solaris'.
    
    This thinko caused us to not substitute our own getopt() code,
    which results in failing to parse long options for the postmaster
    since Solaris' getopt() doesn't do what we expect.  This can be seen
    in the results of buildfarm member icarus, which is the only one
    trying to build via meson on Solaris.
    
    Per consultation with pgsql-release, it seems okay to fix this
    now even though we're in release freeze.  The fix visibly won't
    affect any other platforms, and it can't break Solaris/meson
    builds any worse than they're already broken.
    
    Discussion: https://postgr.es/m/2471229.1770499291@sss.pgh.pa.us
    Backpatch-through: 16


 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 8e378123365..313a4640d56 100644
--- a/meson.build
+++ b/meson.build
@@ -2697,7 +2697,7 @@ gnugetopt_dep = cc.find_library('gnugetopt', required: false)
 #   (i.e., allow '-' as a flag character), so use our version on those platforms
 # - We want to use system's getopt_long() only if the system provides struct
 #   option
-always_replace_getopt = host_system in ['windows', 'cygwin', 'openbsd', 'solaris']
+always_replace_getopt = host_system in ['windows', 'cygwin', 'openbsd', 'sunos']
 always_replace_getopt_long = host_system in ['windows', 'cygwin'] or not cdata.has('HAVE_STRUCT_OPTION')
 
 # Required on BSDs


[parent: 5449fd261ea8]