postgres.git / summary / log / commit / refs

commit    5aa03f99fe7cfb1072849960465a040e834a25e2
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Jan 21 23:33:32 2019 +0000
First released in: 12.0, 10.7, 11.2

    Remove useless bms_copy step in RelationGetIndexAttrBitmap.
    
    Seems to be from a bad case of copy-and-paste-itis in commit 665d1fad9.
    It wouldn't be quite so annoying if it didn't contradict the comment
    half a dozen lines above.
    
    David Rowley
    
    Discussion: https://postgr.es/m/CAKJS1f95Dyf8Qkdz4W+PbCmT-HTb54tkqUCC8isa2RVgSJ_pXQ@mail.gmail.com


 src/backend/utils/cache/relcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index d58237f5a15..d5a1017985c 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -5063,7 +5063,7 @@ restart:
 		case INDEX_ATTR_BITMAP_KEY:
 			return uindexattrs;
 		case INDEX_ATTR_BITMAP_PRIMARY_KEY:
-			return bms_copy(relation->rd_pkattr);
+			return pkindexattrs;
 		case INDEX_ATTR_BITMAP_IDENTITY_KEY:
 			return idindexattrs;
 		default:


[parent: 3037b28b89b4]