pgvector.git / summary / log / commit / refs

commit    5b43aaad5a7c47c715730cdbe4e0a3ee20d16dce
Author:   Andrew Kane <andrew@ankane.org>
Date:     Mon Jan 29 07:14:52 2024 +0000

    Removed unneeded item ids


src/hnswinsert.c | 8 ++------ src/hnswvacuum.c | 6 ++---- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hnswinsert.c b/src/hnswinsert.c index fc515286..c3c28857 100644 --- a/src/hnswinsert.c +++ b/src/hnswinsert.c @@ -355,7 +355,6 @@ HnswUpdateNeighborsOnDisk(Relation index, FmgrInfo *procinfo, Oid collation, Hns Buffer buf; Page page; GenericXLogState *state; - ItemId itemid; HnswNeighborTuple ntup; int idx = -1; int startIdx; @@ -395,8 +394,7 @@ HnswUpdateNeighborsOnDisk(Relation index, FmgrInfo *procinfo, Oid collation, Hns } /* Get tuple */ - itemid = PageGetItemId(page, offno); - ntup = (HnswNeighborTuple) PageGetItem(page, itemid); + ntup = (HnswNeighborTuple) PageGetItem(page, PageGetItemId(page, offno)); /* Calculate index for update */ startIdx = (neighborElement->level - lc) * m; @@ -451,7 +449,6 @@ AddDuplicateOnDisk(Relation index, HnswElement element, HnswElement dup, bool bu Buffer buf; Page page; GenericXLogState *state; - ItemId itemid; HnswElementTuple etup; int i; @@ -470,8 +467,7 @@ AddDuplicateOnDisk(Relation index, HnswElement element, HnswElement dup, bool bu } /* Find space */ - itemid = PageGetItemId(page, dup->offno); - etup = (HnswElementTuple) PageGetItem(page, itemid); + etup = (HnswElementTuple) PageGetItem(page, PageGetItemId(page, dup->offno)); for (i = 0; i < HNSW_HEAPTIDS; i++) { if (!ItemPointerIsValid(&etup->heaptids[i])) diff --git a/src/hnswvacuum.c b/src/hnswvacuum.c index c80b9552..7c14e546 100644 --- a/src/hnswvacuum.c +++ b/src/hnswvacuum.c @@ -60,8 +60,7 @@ RemoveHeapTids(HnswVacuumState * vacuumstate) /* Iterate over nodes */ for (offno = FirstOffsetNumber; offno <= maxoffno; offno = OffsetNumberNext(offno)) { - ItemId itemid = PageGetItemId(page, offno); - HnswElementTuple etup = (HnswElementTuple) PageGetItem(page, itemid); + HnswElementTuple etup = (HnswElementTuple) PageGetItem(page, PageGetItemId(page, offno)); int idx = 0; bool itemUpdated = false; @@ -477,8 +476,7 @@ MarkDeleted(HnswVacuumState * vacuumstate) /* Update element and neighbors together */ for (offno = FirstOffsetNumber; offno <= maxoffno; offno = OffsetNumberNext(offno)) { - ItemId itemid = PageGetItemId(page, offno); - HnswElementTuple etup = (HnswElementTuple) PageGetItem(page, itemid); + HnswElementTuple etup = (HnswElementTuple) PageGetItem(page, PageGetItemId(page, offno)); HnswNeighborTuple ntup; Buffer nbuf; Page npage; [parent: 797ce8034c99]