postgres.git / summary / log / commit / refs

commit    5c85d1122b935a30f7cfb6a09ba282322b3b6bee
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Nov 12 20:14:51 2010 +0000
First released in: 9.1.0, 8.1.23, 8.2.19, 8.3.13, 8.4.6, 9.0.2

    Fix old oversight in const-simplification of COALESCE() expressions.
    
    Once we have found a non-null constant argument, there is no need to
    examine additional arguments of the COALESCE.  The previous coding got it
    right only if the constant was in the first argument position; otherwise
    it tried to simplify following arguments too, leading to unexpected
    behavior like this:
    
    regression=# select coalesce(f1, 42, 1/0) from int4_tbl;
    ERROR:  division by zero
    
    It's a minor corner case, but a bug is a bug, so back-patch all the way.


 src/backend/optimizer/util/clauses.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
index f6ec7a64d54..d23578455cb 100644
--- a/src/backend/optimizer/util/clauses.c
+++ b/src/backend/optimizer/util/clauses.c
@@ -2733,7 +2733,9 @@ eval_const_expressions_mutator(Node *node,
 			/*
 			 * We can remove null constants from the list. For a non-null
 			 * constant, if it has not been preceded by any other
-			 * non-null-constant expressions then that is the result.
+			 * non-null-constant expressions then it is the result.  Otherwise,
+			 * it's the next argument, but we can drop following arguments
+			 * since they will never be reached.
 			 */
 			if (IsA(e, Const))
 			{
@@ -2741,6 +2743,8 @@ eval_const_expressions_mutator(Node *node,
 					continue;	/* drop null constant */
 				if (newargs == NIL)
 					return e;	/* first expr */
+				newargs = lappend(newargs, e);
+				break;
 			}
 			newargs = lappend(newargs, e);
 		}


[parent: d434e8f6ad25]