pgpool2.git / summary / log / commit / refs

commit    60e10c6cdce9e7849f1ed2255cfdca21ef5c575e
Author:   Tatsuo Ishii <ishii@sraoss.co.jp>
Date:     Fri May 12 08:16:01 2023 +0000

    Test: stabilize some tests.
    
    069.memory_leak_extended, 070.memory_leak_extended_memqcache and
    073.pg_terminate_backend uses "sleep 1" to confirm pgpool starting up,
    which makes the tests unstable because there's no guarantee that pgpool
    becomes ready within 1 second. Use wait_for_pgpool_startup instead to
    stabilize the tests.


 src/test/regression/tests/069.memory_leak_extended/test.sh           | 2 +-
 src/test/regression/tests/070.memory_leak_extended_memqcache/test.sh | 2 +-
 src/test/regression/tests/073.pg_terminate_backend/test.sh           | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/regression/tests/069.memory_leak_extended/test.sh b/src/test/regression/tests/069.memory_leak_extended/test.sh
index 505fe2f61..975becbec 100755
--- a/src/test/regression/tests/069.memory_leak_extended/test.sh
+++ b/src/test/regression/tests/069.memory_leak_extended/test.sh
@@ -30,7 +30,7 @@ do
 	# start pgpool-II
 	./startall
 
-	sleep 1
+	wait_for_pgpool_startup
 
 	# initialize tables
 	$PGBENCH -i test
diff --git a/src/test/regression/tests/070.memory_leak_extended_memqcache/test.sh b/src/test/regression/tests/070.memory_leak_extended_memqcache/test.sh
index ccf6b8d17..4a2badb51 100755
--- a/src/test/regression/tests/070.memory_leak_extended_memqcache/test.sh
+++ b/src/test/regression/tests/070.memory_leak_extended_memqcache/test.sh
@@ -35,7 +35,7 @@ do
 	# start pgpool-II
 	./startall
 
-	sleep 1
+	wait_for_pgpool_startup
 
 	# initialize tables
 	$PGBENCH -i test
diff --git a/src/test/regression/tests/073.pg_terminate_backend/test.sh b/src/test/regression/tests/073.pg_terminate_backend/test.sh
index 0cdc7c897..4e2b9ab25 100755
--- a/src/test/regression/tests/073.pg_terminate_backend/test.sh
+++ b/src/test/regression/tests/073.pg_terminate_backend/test.sh
@@ -27,7 +27,7 @@ do
 	# start pgpool-II
 	./startall
 
-	sleep 1
+	wait_for_pgpool_startup
 
 	$PSQL test -p $PGPORT -c "SELECT pg_sleep(10);" &
 


[parent: 15c6250d68ce]