postgres.git / summary / log / commit / refs

commit    610c65064732d25e7a0066ea49b56433b9c2cc4c
Author:   Daniel Gustafsson <dgustafsson@postgresql.org>
Date:     Wed Oct 09 07:34:34 2024 +0000
First released in: 18.0, 12.21, 13.17, 14.14, 15.9, 16.5, 17.1

    Remove incorrect function import from pgindent
    
    Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
    imported the devnull function from File::Spec, but the module does
    not export anything.  In recent versions of Perl calling a missing
    import function cause a warning, which combined with warnings being
    fatal cause pgindent to error out.
    
    Backpatch to all supported versions.
    
    Author: Erik Wienhold <ewie@ewie.name>
    Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
    Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
    Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
    Backpatch-through: v12


 src/tools/pgindent/pgindent | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
index d0ecc28400f..7eaa55d300c 100755
--- a/src/tools/pgindent/pgindent
+++ b/src/tools/pgindent/pgindent
@@ -5,7 +5,7 @@ use warnings;
 
 use Cwd qw(abs_path getcwd);
 use File::Find;
-use File::Spec qw(devnull);
+use File::Spec;
 use File::Temp;
 use IO::Handle;
 use Getopt::Long;


[parent: 5e0431c32a8f]