postgres.git / summary / log / commit / refs

commit    6143602ebaab4fb7c8fca64bbbc246710b5c5ee6
Author:   Andres Freund <andres@anarazel.de>
Date:     Thu Jul 06 15:34:17 2023 +0000
First released in: 17.0, 11.21, 12.16, 13.12, 14.9, 15.4, 16.0

    Fix type of iterator variable in SH_START_ITERATE
    
    Also add comment to make the reasoning behind the Assert() more explicit (per
    Tom).
    
    Reported-by: Ranier Vilela
    Discussion: https://postgr.es/m/CAEudQAocXNJ6s1VLz+hMamLAQAiewRoW17OJ6-+9GACKfj6iPQ@mail.gmail.com
    Backpatch: 11-


 src/include/lib/simplehash.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/include/lib/simplehash.h b/src/include/lib/simplehash.h
index de6a2ac6458..022d72344c4 100644
--- a/src/include/lib/simplehash.h
+++ b/src/include/lib/simplehash.h
@@ -760,7 +760,7 @@ SH_DELETE(SH_TYPE * tb, SH_KEY_TYPE key)
 SH_SCOPE void
 SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)
 {
-	int			i;
+	uint32		i;
 	uint64		startelem = PG_UINT64_MAX;
 
 	/*
@@ -779,6 +779,7 @@ SH_START_ITERATE(SH_TYPE * tb, SH_ITERATOR * iter)
 		}
 	}
 
+	/* we should have found an empty element */
 	Assert(startelem < SH_MAX_SIZE);
 
 	/*


[parent: 2e99ce68bcd2]