postgres.git / summary / log / commit / refs

commit    61de81a496dcd50187e8de765f4c3ed0267764ef
Author:   Peter Geoghegan <pg@bowt.ie>
Date:     Fri Oct 10 18:52:23 2025 +0000
First released in: 19.0, 13.23, 14.20, 15.15, 16.11, 17.7, 18.1

    Remove overzealous _bt_killitems assertion.
    
    An assertion in _bt_killitems expected the scan's currPos state to
    contain a valid LSN, saved from when currPos's page was initially read.
    The assertion failed to account for the fact that even logged relations
    can have leaf pages with an invalid LSN when built with wal_level set to
    "minimal".  Remove the faulty assertion.
    
    Oversight in commit e6eed40e (though note that the assertion was
    backpatched to stable branches before 18 by commit 7c319f54).
    
    Author: Peter Geoghegan <pg@bowt.ie>
    Reported-By: Matthijs van der Vleuten <postgresql@zr40.nl>
    Bug: #19082
    Discussion: https://postgr.es/m/19082-628e62160dbbc1c1@postgresql.org
    Backpatch-through: 13


src/backend/access/nbtree/nbtutils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backend/access/nbtree/nbtutils.c b/src/backend/access/nbtree/nbtutils.c index 9aed207995f..80887df1492 100644 --- a/src/backend/access/nbtree/nbtutils.c +++ b/src/backend/access/nbtree/nbtutils.c @@ -3292,7 +3292,6 @@ _bt_killitems(IndexScanDesc scan) buf = _bt_getbuf(rel, so->currPos.currPage, BT_READ); latestlsn = BufferGetLSNAtomic(buf); - Assert(!XLogRecPtrIsInvalid(so->currPos.lsn)); Assert(so->currPos.lsn <= latestlsn); if (so->currPos.lsn != latestlsn) { [parent: ed047ce0a881]