postgres.git / summary / log / commit / refs
commit 62e1e28bf76910ffe47ddbc5c1fade41e1a65dac
Author: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon Jan 23 18:50:49 2023 +0000
First released in: 16.0
Fix pgindent --show-diff option.
At least on my machine, the initial coding of this didn't actually
work, because interpolation of "$post_fh->filename" doesn't act
as intended.
I threw in some double quotes too, just in case anybody tries
to run this in a path containing spaces.
src/tools/pgindent/pgindent | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent
index 73caa831d0a..5eff1f8032d 100755
--- a/src/tools/pgindent/pgindent
+++ b/src/tools/pgindent/pgindent
@@ -299,12 +299,13 @@ sub show_diff
my $source_filename = shift;
my $post_fh = new File::Temp(TEMPLATE => "pgdiffXXXXX");
+ my $post_fh_filename = $post_fh->filename;
print $post_fh $indented;
$post_fh->close();
- my $diff = `diff -upd $source_filename $post_fh->filename 2>&1`;
+ my $diff = `diff -upd "$source_filename" "$post_fh_filename" 2>&1`;
return $diff;
}
[parent: 3cece34be842]