postgres.git / summary / log / commit / refs

commit    63a601457da46cefe781a9ffd41924327782a78a
Author:   Itagaki Takahiro <itagaki.takahiro@gmail.com>
Date:     Wed Jun 09 01:00:32 2010 +0000
First released in: 9.0.0, 7.4.30, 8.0.26, 8.1.22, 8.2.18, 8.3.12, 8.4.5

    Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
    end with "duplicate connection name" errors.
    
    Backported to release 7.4.


 contrib/dblink/dblink.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index b239ba33163..69997511abd 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -2124,9 +2124,14 @@ createNewConnection(const char *name, remoteConn * con)
 				 errmsg("out of memory")));
 
 	if (found)
+	{
+		PQfinish(rconn->conn);
+		pfree(rconn);
+
 		ereport(ERROR,
 				(errcode(ERRCODE_DUPLICATE_OBJECT),
 				 errmsg("duplicate connection name")));
+	}
 
 	hentry->rcon = con;
 	strncpy(hentry->name, name, NAMEDATALEN - 1);


[parent: 9d1f44113dd8]