postgres.git / summary / log / commit / refs

commit    63e045c2dcf53eb56d2851acc1236c31f3098a95
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Wed Nov 22 00:32:34 2023 +0000
First released in: 17.0, 12.18, 13.14, 14.11, 15.6, 16.2

    Fix query checking consistency of table amhandlers in opr_sanity.sql
    
    As written, the query checked for an access method of type 's', which is
    not an AM type supported in the core code.
    
    Error introduced by 8586bf7ed888.  As this query is not checking what it
    should, backpatch all the way down.
    
    Reviewed-by: Aleksander Alekseev
    Discussion: https://postgr.es/m/ZVxJkAJrKbfHETiy@paquier.xyz
    Backpatch-through: 12


 src/test/regress/expected/opr_sanity.out | 2 +-
 src/test/regress/sql/opr_sanity.sql      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/test/regress/expected/opr_sanity.out b/src/test/regress/expected/opr_sanity.out
index f27217c52d1..ba5875dc5cb 100644
--- a/src/test/regress/expected/opr_sanity.out
+++ b/src/test/regress/expected/opr_sanity.out
@@ -1887,7 +1887,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND
 -- Check for table amhandler functions with the wrong signature
 SELECT a1.oid, a1.amname, p1.oid, p1.proname
 FROM pg_am AS a1, pg_proc AS p1
-WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND
+WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND
     (p1.prorettype != 'table_am_handler'::regtype
      OR p1.proretset
      OR p1.pronargs != 1
diff --git a/src/test/regress/sql/opr_sanity.sql b/src/test/regress/sql/opr_sanity.sql
index 2b292851e3a..0f039f2c83b 100644
--- a/src/test/regress/sql/opr_sanity.sql
+++ b/src/test/regress/sql/opr_sanity.sql
@@ -1195,7 +1195,7 @@ WHERE p1.oid = a1.amhandler AND a1.amtype = 'i' AND
 
 SELECT a1.oid, a1.amname, p1.oid, p1.proname
 FROM pg_am AS a1, pg_proc AS p1
-WHERE p1.oid = a1.amhandler AND a1.amtype = 's' AND
+WHERE p1.oid = a1.amhandler AND a1.amtype = 't' AND
     (p1.prorettype != 'table_am_handler'::regtype
      OR p1.proretset
      OR p1.pronargs != 1


[parent: 0177fc773e3c]