pgbackrest.git / summary / log / commit / refs
commit 64b97fd7ca3410cd6bca3c01bc438bb104191f78
Author: David Steele <david@crunchydata.com>
Date: Fri Nov 30 15:55:29 2018 +0000
Correct archive-get-queue-max to be size type.
This somehow was not configured as a size option when it was added. It worked, but queue sizes could not be specified in shorthand, e.g. 128GB.
This is not a breaking change because currently configured integer values will be read as bytes.
Reported by Ronan Dunklau.
build/lib/pgBackRestBuild/Config/Data.pm | 2 +-
doc/xml/release.xml | 13 +++++++++++++
src/config/define.auto.c | 2 +-
3 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/build/lib/pgBackRestBuild/Config/Data.pm b/build/lib/pgBackRestBuild/Config/Data.pm
index e4a6b57d7..eb21edf54 100644
--- a/build/lib/pgBackRestBuild/Config/Data.pm
+++ b/build/lib/pgBackRestBuild/Config/Data.pm
@@ -1970,7 +1970,7 @@ my %hConfigDefine =
&CFGOPT_ARCHIVE_GET_QUEUE_MAX =>
{
&CFGDEF_SECTION => CFGDEF_SECTION_GLOBAL,
- &CFGDEF_TYPE => CFGDEF_TYPE_INTEGER,
+ &CFGDEF_TYPE => CFGDEF_TYPE_SIZE,
&CFGDEF_DEFAULT => 128 * 1024 * 1024, # 128MB
&CFGDEF_ALLOW_RANGE => [0, 4 * 1024 * 1024 * 1024 * 1024 * 1024], # 0-4PB
&CFGDEF_COMMAND =>
diff --git a/doc/xml/release.xml b/doc/xml/release.xml
index 193161476..d72feb9e6 100644
--- a/doc/xml/release.xml
+++ b/doc/xml/release.xml
@@ -22,6 +22,14 @@
<p>Remove request for S3 object info directly after putting it.</p>
</release-item>
+
+ <release-item>
+ <release-item-contributor-list>
+ <release-item-ideator id="ronan.dunklau"/>
+ </release-item-contributor-list>
+
+ <p>Correct <br-option>archive-get-queue-max</br-option> to be <id>size</id> type.</p>
+ </release-item>
</release-bug-list>
<release-development-list>
@@ -5967,6 +5975,11 @@
<contributor-id type="github">nj3110</contributor-id>
</contributor>
+ <contributor id="ronan.dunklau">
+ <contributor-name-display>Ronan Dunklau</contributor-name-display>
+ <contributor-id type="github">rdunklau</contributor-id>
+ </contributor>
+
<contributor id="sarah.conway">
<contributor-name-display>Sarah Conway</contributor-name-display>
<contributor-id type="github">xenophenes</contributor-id>
diff --git a/src/config/define.auto.c b/src/config/define.auto.c
index 0428c43d7..56688394c 100644
--- a/src/config/define.auto.c
+++ b/src/config/define.auto.c
@@ -348,7 +348,7 @@ static ConfigDefineOptionData configDefineOptionData[] = CFGDEFDATA_OPTION_LIST
CFGDEFDATA_OPTION_NAME("archive-get-queue-max")
CFGDEFDATA_OPTION_REQUIRED(true)
CFGDEFDATA_OPTION_SECTION(cfgDefSectionGlobal)
- CFGDEFDATA_OPTION_TYPE(cfgDefOptTypeInteger)
+ CFGDEFDATA_OPTION_TYPE(cfgDefOptTypeSize)
CFGDEFDATA_OPTION_INTERNAL(false)
CFGDEFDATA_OPTION_INDEX_TOTAL(1)
[parent: 1ad67644dade]