postgres.git / summary / log / commit / refs

commit    6bc7873da1c3e9f1d870fa2d671eb450ea6c9753
Author:   Peter Eisentraut <peter@eisentraut.org>
Date:     Thu Jun 29 08:30:55 2023 +0000

    Remove inappropriate raw_expression_tree_walker() code
    
    It was walking into the ColumnDef->compression field, which is not a
    node but a string.  This code is currently not reachable (because the
    compression field is only set in situations that don't go through
    raw_expression_tree_walker()), but if it had been, this could have
    behaved erratically.


 src/backend/nodes/nodeFuncs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c
index 94b697b7a27..d203702c13e 100644
--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -3924,8 +3924,6 @@ raw_expression_tree_walker(Node *node,
 
 				if (walker(coldef->typeName, context))
 					return true;
-				if (walker(coldef->compression, context))
-					return true;
 				if (walker(coldef->raw_default, context))
 					return true;
 				if (walker(coldef->collClause, context))


[parent: 7e8349cbd7f7]