postgres.git / summary / log / commit / refs

commit    6d60b718ceb09603eb26b6d6788b5c19c04ec5eb
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Thu Apr 20 22:12:32 2023 +0000

    Use --strip-unneeded when stripping static libraries with GNU strip.
    
    We've long used "--strip-unneeded" for shared libraries but plain
    "-x" for static libraries when stripping symbols with GNU strip.
    There doesn't seem to be any really good reason for that though,
    since --strip-unneeded produces smaller output (as "-x" alone
    does not remove debug symbols).  Moreover it seems that
    llvm-strip, although it identifies as GNU strip, misbehaves when
    given "-x" for this purpose.  It's unclear whether that's
    intentional or a bug in llvm-strip, but in any case it seems like
    changing to use --strip-unneeded in all cases should be a win.
    
    Note that this doesn't change our behavior when dealing with
    non-GNU strip.
    
    Per gripes from Ed Maste and Palle Girgensohn.  Back-patch,
    in case anyone wants to use llvm-strip with stable branches.
    
    Discussion: https://postgr.es/m/17898-5308d09543463266@postgresql.org
    Discussion: https://postgr.es/m/20230420153338.bbj2g5jiyy3afhjz@awork3.anarazel.de


 config/programs.m4 | 2 +-
 configure          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/programs.m4 b/config/programs.m4
index 6a118ece24e..e936dbd07a5 100644
--- a/config/programs.m4
+++ b/config/programs.m4
@@ -327,7 +327,7 @@ AC_DEFUN([PGAC_CHECK_STRIP],
 
   AC_MSG_CHECKING([whether it is possible to strip libraries])
   if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then
-    STRIP_STATIC_LIB="$STRIP -x"
+    STRIP_STATIC_LIB="$STRIP --strip-unneeded"
     STRIP_SHARED_LIB="$STRIP --strip-unneeded"
     AC_MSG_RESULT(yes)
   else
diff --git a/configure b/configure
index 7ba22b953a9..b4a5cdae419 100755
--- a/configure
+++ b/configure
@@ -9502,7 +9502,7 @@ fi
   { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether it is possible to strip libraries" >&5
 $as_echo_n "checking whether it is possible to strip libraries... " >&6; }
   if test x"$STRIP" != x"" && "$STRIP" -V 2>&1 | grep "GNU strip" >/dev/null; then
-    STRIP_STATIC_LIB="$STRIP -x"
+    STRIP_STATIC_LIB="$STRIP --strip-unneeded"
     STRIP_SHARED_LIB="$STRIP --strip-unneeded"
     { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5
 $as_echo "yes" >&6; }


[parent: b79b36f269bb]