postgres.git / summary / log / commit / refs

commit    6dc3fd90f126fa409eac51a4182ee09b9d63c16c
Author:   Álvaro Herrera <alvherre@kurilemu.de>
Date:     Mon Sep 28 15:41:38 2026 +0000

    Turn "check" into assertion
    
    In commit 1813f951cad5, I mistakenly assumed that one particular
    function named CheckSomething() checks Something.  It doesn't, it merely
    return the state to check.  Fix by adding the necessary Assert() call.
    
    Good chance to add trailers for commit 1813f951cad5:
    Reviewed-by: Manuel Reyes Bravo <manuelreyesbravo@gmail.com>
    Reviewed-by: Antonin Houska <ah@cybertec.at>
    Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
    
    Backpatch-through: 19
    Discussion: https://postgr.es/m/CAA-aLv5MF6BLL+BWvix2Yw+CBardtH43AofPReQunhDZPNBtuA@mail.gmail.com


 src/backend/commands/repack.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/commands/repack.c b/src/backend/commands/repack.c
index d7585312e17..596c1abaf78 100644
--- a/src/backend/commands/repack.c
+++ b/src/backend/commands/repack.c
@@ -1455,8 +1455,8 @@ copy_table_data(Relation NewHeap, Relation OldHeap, Relation OldIndex,
 		if (!concurrent)
 			LockRelationOid(OldHeap->rd_rel->reltoastrelid, lmode);
 		else
-			CheckRelationOidLockedByMe(OldHeap->rd_rel->reltoastrelid,
-									   lmode, false);
+			Assert(CheckRelationOidLockedByMe(OldHeap->rd_rel->reltoastrelid,
+											  lmode, false));
 	}
 
 	/*


[parent: 1813f951cad5]