postgrespro.git / summary / log / commit / refs

commit    6eebfdc38b173edcd179f422cf7083383edb24bc
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Mar 14 05:14:49 2019 +0000

    Fix thinko when bumping on temporary directories in pg_checksums
    
    This fixes an oversight from 5c99513.  This has no actual consequence as
    PG_TEMP_FILE_PREFIX and PG_TEMP_FILES_DIR have the same value so when
    bumping on a temporary path the directory scan was still moving on to
    the next entry instead of skipping the rest of the scan, but let's keep
    the logic correct.
    
    Author: Michael Banck
    Reviewed-by: Kyotaro Horiguchi
    Discussion: https://postgr.es/m/20190314.115417.58230569.horiguchi.kyotaro@lab.ntt.co.jp
    Backpatch-through: 11


 src/bin/pg_checksums/pg_checksums.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/pg_checksums/pg_checksums.c b/src/bin/pg_checksums/pg_checksums.c
index 6571c34211..5d4083fa9f 100644
--- a/src/bin/pg_checksums/pg_checksums.c
+++ b/src/bin/pg_checksums/pg_checksums.c
@@ -171,7 +171,7 @@ scan_directory(const char *basedir, const char *subdir)
 		if (strncmp(de->d_name,
 					PG_TEMP_FILES_DIR,
 					strlen(PG_TEMP_FILES_DIR)) == 0)
-			return;
+			continue;
 
 		snprintf(fn, sizeof(fn), "%s/%s", path, de->d_name);
 		if (lstat(fn, &st) < 0)


[parent: 401b87a24fba]