postgres.git / summary / log / commit / refs

commit    73af46e82c501ec9122fd27c39c709f1d6fecc17
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sun Nov 18 22:15:27 2012 +0000

    Limit values of archive_timeout, post_auth_delay, auth_delay.milliseconds.
    
    The previous definitions of these GUC variables allowed them to range
    up to INT_MAX, but in point of fact the underlying code would suffer
    overflows or other errors with large values.  Reduce the maximum values
    to something that won't misbehave.  There's no apparent value in working
    harder than this, since very large delays aren't sensible for any of
    these.  (Note: the risk with archive_timeout is that if we're late
    checking the state, the timestamp difference it's being compared to
    might overflow.  So we need some amount of slop; the choice of INT_MAX/2
    is arbitrary.)
    
    Per followup investigation of bug #7670.  Although this isn't a very
    significant fix, might as well back-patch.


 src/backend/utils/misc/guc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 0ceb89fd504..f340214f1d4 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -1239,7 +1239,7 @@ static struct config_int ConfigureNamesInt[] =
 			GUC_UNIT_S
 		},
 		&XLogArchiveTimeout,
-		0, 0, INT_MAX, NULL, NULL
+		0, 0, INT_MAX / 2, NULL, NULL
 	},
 	{
 		{"post_auth_delay", PGC_BACKEND, DEVELOPER_OPTIONS,
@@ -1248,7 +1248,7 @@ static struct config_int ConfigureNamesInt[] =
 			GUC_NOT_IN_SAMPLE | GUC_UNIT_S
 		},
 		&PostAuthDelay,
-		0, 0, INT_MAX, NULL, NULL
+		0, 0, INT_MAX / 1000000, NULL, NULL
 	},
 	{
 		{"default_statistics_target", PGC_USERSET, QUERY_TUNING_OTHER,


[parent: 694f4ff83525]