postgres.git / summary / log / commit / refs

commit    75bcba6cbd2a6f62752d7917d9a3c0a52f8605c9
Author:   Alexander Korotkov <akorotkov@postgresql.org>
Date:     Wed Feb 21 00:46:56 2024 +0000

    Remove extra check_stack_depth() from dropconstraint_internal()
    
    The second check was added by d57b7cc33 without taking into account there
    is already a check since b0f7dd915.
    
    Reported-by: Ashutosh Bapat, Alexander Lakhin
    Discussion: https://postgr.es/m/CAExHW5sBZWDjeBUFs_ehEDM%2BuhWxTiBkPbLiat7ZjWkb-DWQWw%40mail.gmail.com


 src/backend/commands/tablecmds.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 679dee10da4..f7987945563 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -12738,9 +12738,6 @@ dropconstraint_internal(Relation rel, HeapTuple constraintTup, DropBehavior beha
 	/* Guard against stack overflow due to overly deep inheritance tree. */
 	check_stack_depth();
 
-	/* since this function recurses, it could be driven to stack overflow */
-	check_stack_depth();
-
 	/* At top level, permission check was done in ATPrepCmd, else do it */
 	if (recursing)
 		ATSimplePermissions(AT_DropConstraint, rel, ATT_TABLE | ATT_FOREIGN_TABLE);


[parent: fcd210d496da]