postgres.git / summary / log / commit / refs

commit    8014c61ebda10d39ef8855b4826aeba5cacd36e1
Author:   Andres Freund <andres@anarazel.de>
Date:     Wed Mar 23 20:05:25 2022 +0000
First released in: 15.0, 10.21, 11.16, 12.11, 13.7, 14.3

    Don't call fwrite() with len == 0 when writing out relcache init file.
    
    Noticed via -fsanitize=undefined.
    
    Backpatch to all branches, for the same reasons as 46ab07ffda9.
    
    Discussion: https://postgr.es/m/20220323173537.ll7klrglnp4gn2um@alap3.anarazel.de
    Backpatch: 10-


 src/backend/utils/cache/relcache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 7976a0d66d4..54de0721815 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -6365,7 +6365,7 @@ write_item(const void *data, Size len, FILE *fp)
 {
 	if (fwrite(&len, 1, sizeof(len), fp) != sizeof(len))
 		elog(FATAL, "could not write init file");
-	if (fwrite(data, 1, len, fp) != len)
+	if (len > 0 && fwrite(data, 1, len, fp) != len)
 		elog(FATAL, "could not write init file");
 }
 


[parent: 7c163aa93fe6]