postgres.git / summary / log / commit / refs

commit    80e2694b284cd9395b1ee8ef476f5f720ee50566
Author:   Robert Haas <rhaas@postgresql.org>
Date:     Mon Sep 28 14:47:05 2015 +0000
First released in: 9.6.0, 9.5.0

    Don't try to create a temp install without abs_top_builddir.
    
    Otherwise, we effectively act as if abs_top_builddir were the root
    directory, which is quite dangerous if the user happens to have
    permissions to do things there.  This can crop up in PGXS builds,
    for example.
    
    Report by Sandro Santilli, patch by me, review by Noah Misch.


 src/Makefile.global.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index e2c8aeacd40..13755148b55 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -320,6 +320,7 @@ check: temp-install
 .PHONY: temp-install
 temp-install:
 ifndef NO_TEMP_INSTALL
+ifneq ($(abs_top_builddir),)
 ifeq ($(MAKELEVEL),0)
 	rm -rf '$(abs_top_builddir)'/tmp_install
 	$(MKDIR_P) '$(abs_top_builddir)'/tmp_install/log
@@ -327,6 +328,7 @@ ifeq ($(MAKELEVEL),0)
 endif
 	$(if $(EXTRA_INSTALL),for extra in $(EXTRA_INSTALL); do $(MAKE) -C '$(top_builddir)'/$$extra DESTDIR='$(abs_top_builddir)'/tmp_install install >>'$(abs_top_builddir)'/tmp_install/log/install.log || exit; done)
 endif
+endif
 
 PROVE = @PROVE@
 PG_PROVE_FLAGS = -I $(top_srcdir)/src/test/perl/


[parent: 27af56b59515]