postgres.git / summary / log / commit / refs

commit    8126bfb5b5f0b413455edd23ff3bf08d83f1cddc
Author:   Stephen Frost <sfrost@snowman.net>
Date:     Mon Jul 15 01:17:59 2013 +0000
First released in: 9.4.0, 9.3.0

    Check version before allocating PQExpBuffer
    
    In pg_dump.c:getEventTriggers, check what major version we are on
    before calling createPQExpBuffer() to avoid leaking that bit of
    memory.
    
    Leak discovered by the Coverity scanner.
    
    Back-patch to 9.3 where support for dumping event triggers was
    added.


 src/bin/pg_dump/pg_dump.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index becc82be91e..f74935e0b93 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -5746,7 +5746,7 @@ EventTriggerInfo *
 getEventTriggers(Archive *fout, int *numEventTriggers)
 {
 	int			i;
-	PQExpBuffer query = createPQExpBuffer();
+	PQExpBuffer query;
 	PGresult   *res;
 	EventTriggerInfo *evtinfo;
 	int			i_tableoid,
@@ -5766,6 +5766,8 @@ getEventTriggers(Archive *fout, int *numEventTriggers)
 		return NULL;
 	}
 
+	query = createPQExpBuffer();
+
 	/* Make sure we are in proper schema */
 	selectSourceSchema(fout, "pg_catalog");
 


[parent: b68a1fc7ff1a]