postgres.git / summary / log / commit / refs

commit    85b3bcbcd61cc1b5aac35e53edc67abd1bceee08
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Wed May 03 23:37:01 2017 +0000

    Remove useless and rather expensive stanza in matview regression test.
    
    This removes a test case added by commit b69ec7cc9, which was intended
    to exercise a corner case involving the rule used at that time that
    materialized views were unpopulated iff they had physical size zero.
    We got rid of that rule very shortly later, in commit 1d6c72a55, but
    kept the test case.  However, because the case now asks what VACUUM
    will do to a zero-sized physical file, it would be pretty surprising
    if the answer were ever anything but "nothing" ... and if things were
    indeed that broken, surely we'd find it out from other tests.  Since
    the test involves a table that's fairly large by regression-test
    standards (100K rows), it's quite slow to run.  Dropping it should
    save some buildfarm cycles, so let's do that.
    
    Discussion: https://postgr.es/m/32386.1493831320@sss.pgh.pa.us


 src/test/regress/expected/matview.out | 20 --------------------
 src/test/regress/sql/matview.sql      | 12 ------------
 2 files changed, 32 deletions(-)

diff --git a/src/test/regress/expected/matview.out b/src/test/regress/expected/matview.out
index 9f6795daf67..e600fa20034 100644
--- a/src/test/regress/expected/matview.out
+++ b/src/test/regress/expected/matview.out
@@ -365,26 +365,6 @@ NOTICE:  drop cascades to 3 other objects
 DETAIL:  drop cascades to view v_test2
 drop cascades to materialized view mv_test2
 drop cascades to materialized view mv_test3
--- test that vacuum does not make empty matview look unpopulated
-CREATE TABLE hoge (i int);
-INSERT INTO hoge VALUES (generate_series(1,100000));
-CREATE MATERIALIZED VIEW hogeview AS SELECT * FROM hoge WHERE i % 2 = 0;
-CREATE INDEX hogeviewidx ON hogeview (i);
-DELETE FROM hoge;
-REFRESH MATERIALIZED VIEW hogeview;
-SELECT * FROM hogeview WHERE i < 10;
- i 
----
-(0 rows)
-
-VACUUM ANALYZE hogeview;
-SELECT * FROM hogeview WHERE i < 10;
- i 
----
-(0 rows)
-
-DROP TABLE hoge CASCADE;
-NOTICE:  drop cascades to materialized view hogeview
 -- allow subquery to reference unpopulated matview if WITH NO DATA is specified
 CREATE MATERIALIZED VIEW mv1 AS SELECT 1 AS col1 WITH NO DATA;
 CREATE MATERIALIZED VIEW mv2 AS SELECT * FROM mv1
diff --git a/src/test/regress/sql/matview.sql b/src/test/regress/sql/matview.sql
index bc10146a27f..50c344c74c3 100644
--- a/src/test/regress/sql/matview.sql
+++ b/src/test/regress/sql/matview.sql
@@ -113,18 +113,6 @@ SELECT relispopulated FROM pg_class WHERE oid = 'mv_test3'::regclass;
 
 DROP VIEW v_test1 CASCADE;
 
--- test that vacuum does not make empty matview look unpopulated
-CREATE TABLE hoge (i int);
-INSERT INTO hoge VALUES (generate_series(1,100000));
-CREATE MATERIALIZED VIEW hogeview AS SELECT * FROM hoge WHERE i % 2 = 0;
-CREATE INDEX hogeviewidx ON hogeview (i);
-DELETE FROM hoge;
-REFRESH MATERIALIZED VIEW hogeview;
-SELECT * FROM hogeview WHERE i < 10;
-VACUUM ANALYZE hogeview;
-SELECT * FROM hogeview WHERE i < 10;
-DROP TABLE hoge CASCADE;
-
 -- allow subquery to reference unpopulated matview if WITH NO DATA is specified
 CREATE MATERIALIZED VIEW mv1 AS SELECT 1 AS col1 WITH NO DATA;
 CREATE MATERIALIZED VIEW mv2 AS SELECT * FROM mv1


[parent: 35ac926bfb8d]