postgres.git / summary / log / commit / refs

commit    861086493faa9ca5468cc50dd20975ee6c042ffe
Author:   Tomas Vondra <tomas.vondra@postgresql.org>
Date:     Tue Sep 10 14:27:55 2024 +0000
First released in: 18.0

    Add PG_TEST_PG_COMBINEBACKUP_MODE to CI tasks
    
    The environment variable PG_TEST_PG_COMBINEBACKUP_MODE has been
    available since 35a7b288b975, but was not set by any built-in CI tasks.
    This commit modifies two of the CI tasks to use the alternative modes,
    to exercise the pg_combinebackup code.
    
    The Linux task uses --copy-file-range, macOS uses --clone.
    
    This is not an exhaustive test of combinations. The supported modes
    depend on the operating system and filesystem, and it would be nice to
    test all supported combinations. Right now we have just one task for
    each OS, and it doesn't seem worth adding more just for this.
    
    Reported-by: Peter Eisentraut
    Reviewed-by: Peter Eisentraut
    Discussion: https://postgr.es/m/48da4a1f-ccd9-4988-9622-24f37b1de2b4%40eisentraut.org


 .cirrus.tasks.yml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index 1ce6c443a8c..90cb95c8681 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -321,6 +321,7 @@ task:
 
       env:
         SANITIZER_FLAGS: -fsanitize=address
+        PG_TEST_PG_COMBINEBACKUP_MODE: --copy-file-range
 
       # Normally, the "relation segment" code basically has no coverage in our
       # tests, because we (quite reasonably) don't generate tables large
@@ -435,6 +436,7 @@ task:
     CXXFLAGS: -Og -ggdb
 
     PG_TEST_PG_UPGRADE_MODE: --clone
+    PG_TEST_PG_COMBINEBACKUP_MODE: --clone
 
   <<: *macos_task_template
 


[parent: 390b3cbbb2af]