postgres.git / summary / log / commit / refs

commit    87221867e8b8fedb347e32d3d919e62ae85edc81
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sat Jul 25 19:58:14 2015 +0000

    In pg_ctl, report unexpected failure to stat() the postmaster.pid file.
    
    Any error other than ENOENT is a bit suspicious here, and perhaps should
    not be grounds for assuming the postmaster has failed.  For the moment
    though, just report it, and don't change the behavior otherwise.  The
    intent is mainly to try to determine why we are seeing intermittent
    failures in this area on some buildfarm members.
    
    Back-patch to 9.5 where some of these failures have happened.


 src/bin/pg_ctl/pg_ctl.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 74764fabdaf..6a36d29f43b 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -648,7 +648,12 @@ test_postmaster_connection(bool do_checkpoint)
 			struct stat statbuf;
 
 			if (stat(pid_file, &statbuf) != 0)
+			{
+				if (errno != ENOENT)
+					write_stderr(_("\n%s: could not stat file \"%s\": %s\n"),
+								 progname, pid_file, strerror(errno));
 				return PQPING_NO_RESPONSE;
+			}
 
 			if (found_stale_pidfile)
 			{


[parent: 68c3549fb568]