postgres.git / summary / log / commit / refs

commit    8722a1a06aedbbbeb4f848a7b9ee62d6ae8649c6
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sun Nov 27 17:57:11 2011 +0000
First released in: 9.2.0

    Use the proper macro to convert a bool to a Datum.
    
    The original coding was
    	var->value = (Datum) state;
    which is bogus, and then in commit 2f0f7b4bce13e68394543728801ef011fd82fac6
    it was "corrected" to
    	var->value = PointerGetDatum(state);
    which is a faithful translation but still wrong.
    
    This seems purely cosmetic, though, so no need for a back-patch.
    
    Pavel Stehule


 src/pl/plpgsql/src/pl_exec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c
index 387362a59a2..717ad798772 100644
--- a/src/pl/plpgsql/src/pl_exec.c
+++ b/src/pl/plpgsql/src/pl_exec.c
@@ -5850,8 +5850,7 @@ exec_simple_recheck_plan(PLpgSQL_expr *expr, CachedPlan *cplan)
 }
 
 /* ----------
- * exec_set_found			Set the global found variable
- *					to true/false
+ * exec_set_found			Set the global found variable to true/false
  * ----------
  */
 static void
@@ -5860,7 +5859,7 @@ exec_set_found(PLpgSQL_execstate *estate, bool state)
 	PLpgSQL_var *var;
 
 	var = (PLpgSQL_var *) (estate->datums[estate->found_varno]);
-	var->value = PointerGetDatum(state);
+	var->value = BoolGetDatum(state);
 	var->isnull = false;
 }
 


[parent: 4a9018135a37]