postgres.git / summary / log / commit / refs

commit    87a44b6cf98f8d325af0f000f10adedcb7a5b95d
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sat Mar 23 21:40:19 2019 +0000
First released in: 12.0, 9.4.22, 9.5.17, 9.6.13, 10.8, 11.3

    Remove inadequate check for duplicate "xml" PI.
    
    I failed to think about PIs starting with "xml".  We don't really
    need this check at all, so just take it out.  Oversight in
    commit 8d1dadb25 et al.


 src/backend/utils/adt/xml.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index 7dd06c7bc69..62db7b2e8f3 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -1400,10 +1400,6 @@ xml_doctype_in_content(const xmlChar *str)
 		if (!e)
 			return false;
 
-		/* we don't check PIs carefully, but do reject "xml" target */
-		if (e - p >= 3 && xmlStrncasecmp(p, (xmlChar *) "xml", 3) == 0)
-			return false;
-
 		/* advance over PI, keep scanning */
 		p = e + 2;
 	}


[parent: c4c2958c6b8f]