postgres.git / summary / log / commit / refs

commit    8811f5d3a4a1ebf79ccb00da336d70041b003dd2
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sat Oct 08 01:12:25 2016 +0000

    libpqwalreceiver needs to link with libintl when using --enable-nls.
    
    The need for this was previously obscured even on picky platforms
    by the hack we used to support direct cross-module references in
    the transforms contrib modules.  Now that that hack is gone, the
    undefined symbol is exposed, as reported by Robert Haas.
    
    Back-patch to 9.5 where we started to use -Wl,-undefined,dynamic_lookup.
    I'm a bit surprised that the older branches don't seem to contain
    any gettext references in this module, but since they don't fail
    at build time, they must not.  (We might be able to get away with
    leaving this alone in 9.5/9.6, but I think it's cleaner if the
    reference gets resolved at link time.)
    
    Report: <CA+TgmoaHJKU5kcWZcYduATYVT7Mnx+8jUnycaYYL7OtCwCigug@mail.gmail.com>


 src/backend/replication/libpqwalreceiver/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/replication/libpqwalreceiver/Makefile b/src/backend/replication/libpqwalreceiver/Makefile
index 6c95c1ce97b..a7a5fe1ed2b 100644
--- a/src/backend/replication/libpqwalreceiver/Makefile
+++ b/src/backend/replication/libpqwalreceiver/Makefile
@@ -15,7 +15,7 @@ include $(top_builddir)/src/Makefile.global
 override CPPFLAGS := -I$(srcdir) -I$(libpq_srcdir) $(CPPFLAGS)
 
 OBJS = libpqwalreceiver.o $(WIN32RES)
-SHLIB_LINK = $(libpq)
+SHLIB_LINK = $(libpq) $(filter -lintl, $(LIBS))
 SHLIB_PREREQS = submake-libpq
 PGFILEDESC = "libpqwalreceiver - receive WAL during streaming replication"
 NAME = libpqwalreceiver


[parent: b0779abb3add]