postgres.git / summary / log / commit / refs

commit    8c44802b6ed4846accb08e2ffe93040b8b42aae9
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Mon Feb 19 04:32:56 2018 +0000

    Remove redundant initialization of a local variable.
    
    In what was doubtless a typo, commit bf6c614a2 introduced a duplicate
    initialization of a local variable.  This made Coverity unhappy, as well
    as pretty much anybody reading the code.  We don't even have a real use
    for the local variable, so just remove it.


 src/backend/executor/nodeGroup.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/backend/executor/nodeGroup.c b/src/backend/executor/nodeGroup.c
index c6efd64d00d..2ea80e817d4 100644
--- a/src/backend/executor/nodeGroup.c
+++ b/src/backend/executor/nodeGroup.c
@@ -162,7 +162,6 @@ GroupState *
 ExecInitGroup(Group *node, EState *estate, int eflags)
 {
 	GroupState *grpstate;
-	AttrNumber *grpColIdx = grpColIdx = node->grpColIdx;
 
 	/* check for unsupported flags */
 	Assert(!(eflags & (EXEC_FLAG_BACKWARD | EXEC_FLAG_MARK)));
@@ -209,7 +208,7 @@ ExecInitGroup(Group *node, EState *estate, int eflags)
 	grpstate->eqfunction =
 		execTuplesMatchPrepare(ExecGetResultType(outerPlanState(grpstate)),
 							   node->numCols,
-							   grpColIdx,
+							   node->grpColIdx,
 							   node->grpOperators,
 							   &grpstate->ss.ps);
 


[parent: ebf6049ebea1]