postgres.git / summary / log / commit / refs

commit    8f1888eb6d6023b80525fbf7a8a1053daa6eb31e
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Mon Jun 17 05:26:27 2024 +0000
First released in: 17.0

    Make regress function make_tuple_indirect() able to handle plain attributes
    
    The function has been introduced in 368202501539 to test at a low level
    the new kinds of external toast datums, and would fail on OOM when
    dealing with a plain storage attribute.  The existing tests of
    indirect_toast do not test this case, still the error generated was
    confusing.
    
    Author: Alexander Lakhin
    Discussion: https://postgr.es/m/250a21e5-d677-6b2a-2692-cd4233785e37@gmail.com


 src/test/regress/regress.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/test/regress/regress.c b/src/test/regress/regress.c
index deffaea578b..45a6ad3c49e 100644
--- a/src/test/regress/regress.c
+++ b/src/test/regress/regress.c
@@ -595,7 +595,8 @@ make_tuple_indirect(PG_FUNCTION_ARGS)
 		/* only work on existing, not-null varlenas */
 		if (TupleDescAttr(tupdesc, i)->attisdropped ||
 			nulls[i] ||
-			TupleDescAttr(tupdesc, i)->attlen != -1)
+			TupleDescAttr(tupdesc, i)->attlen != -1 ||
+			TupleDescAttr(tupdesc, i)->attstorage == TYPSTORAGE_PLAIN)
 			continue;
 
 		attr = (struct varlena *) DatumGetPointer(values[i]);


[parent: faaa0d279899]