postgrespro.git / summary / log / commit / refs

commit    8f4ee44bcdbcd437f860f2d048125a118335b088
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Wed Apr 15 06:56:01 2020 +0000

    Fix minor memory leak in pg_dump
    
    A query used to read default ACL information from the catalogs did not
    free a set of PQExpBuffer.
    
    Oversight in commit e2090d9, so backpatch down to 9.6.
    
    Author: Jie Zhang
    Reviewed-by: Sawada Masahiko
    Discussion: https://postgr.es/m/05bcbc5857f948efa0b451b85a48ae10@G08CNEXMBPEKD06.g08.fujitsu.local
    Backpatch-through: 9.6


 src/bin/pg_dump/pg_dump.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index c579227b19..5db4f5761d 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -9592,6 +9592,11 @@ getDefaultACLs(Archive *fout, int *numDefaultACLs)
 						  racl_subquery->data,
 						  initacl_subquery->data,
 						  initracl_subquery->data);
+
+		destroyPQExpBuffer(acl_subquery);
+		destroyPQExpBuffer(racl_subquery);
+		destroyPQExpBuffer(initacl_subquery);
+		destroyPQExpBuffer(initracl_subquery);
 	}
 	else
 	{


[parent: a2ac73e7be7a]