postgres.git / summary / log / commit / refs

commit    90474c16a7d24991586aa97c78b880fe9c072aba
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Fri Jul 22 14:53:26 2022 +0000
First released in: 16.0, 15.0

    Fix minor memory leaks in psql's tab completion.
    
    Tang Haiying and Tom Lane
    
    Discussion: https://postgr.es/m/OS0PR01MB6113EA19F05E217C823B4CCAFB909@OS0PR01MB6113.jpnprd01.prod.outlook.com


 src/bin/psql/tab-complete.c | 2 ++
 src/fe_utils/string_utils.c | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 92207d2e160..5f06768085f 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -5158,6 +5158,8 @@ _complete_from_query(const char *simple_query,
 
 		/* Clean up */
 		termPQExpBuffer(&query_buffer);
+		free(schemaname);
+		free(objectname);
 		free(e_object_like);
 		free(e_schemaname);
 		free(e_ref_object);
diff --git a/src/fe_utils/string_utils.c b/src/fe_utils/string_utils.c
index f9ea08705af..a2fa7a0c26a 100644
--- a/src/fe_utils/string_utils.c
+++ b/src/fe_utils/string_utils.c
@@ -1225,4 +1225,7 @@ patternToSQLRegex(int encoding, PQExpBuffer dbnamebuf, PQExpBuffer schemabuf,
 			appendPQExpBufferStr(dbnamebuf, curbuf->data);
 		termPQExpBuffer(curbuf);
 	}
+
+	if (want_literal_dbname)
+		termPQExpBuffer(&left_literal);
 }


[parent: 7d158e8cb44b]