postgres.git / summary / log / commit / refs

commit    9446d7157740a09613175209c9e4eef02d3d92db
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Tue Aug 07 20:32:50 2018 +0000

    Don't record FDW user mappings as members of extensions.
    
    CreateUserMapping has a recordDependencyOnCurrentExtension call that's
    been there since extensions were introduced (very possibly my fault).
    However, there's no support anywhere else for user mappings as members
    of extensions, nor are they listed as a possible member object type in
    the documentation.  Nor does it really seem like a good idea for user
    mappings to belong to extensions when roles don't.  Hence, remove the
    bogus call.
    
    (As we saw in bug #15310, the lack of any pg_dump support for this case
    ensures that any such membership record would silently disappear during
    pg_upgrade.  So there's probably no need for us to do anything else
    about cleaning up after this mistake.)
    
    Discussion: https://postgr.es/m/27952.1533667213@sss.pgh.pa.us


 src/backend/commands/foreigncmds.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/backend/commands/foreigncmds.c b/src/backend/commands/foreigncmds.c
index 9ad991507fa..dd43b073711 100644
--- a/src/backend/commands/foreigncmds.c
+++ b/src/backend/commands/foreigncmds.c
@@ -1231,8 +1231,12 @@ CreateUserMapping(CreateUserMappingStmt *stmt)
 		recordDependencyOnOwner(UserMappingRelationId, umId, useId);
 	}
 
-	/* dependency on extension */
-	recordDependencyOnCurrentExtension(&myself, false);
+	/*
+	 * Perhaps someday there should be a recordDependencyOnCurrentExtension
+	 * call here; but since roles aren't members of extensions, it seems like
+	 * user mappings shouldn't be either.  Note that the grammar and pg_dump
+	 * would need to be extended too if we change this.
+	 */
 
 	/* Post creation hook for new user mapping */
 	InvokeObjectPostCreateHook(UserMappingRelationId, umId, 0);


[parent: 8dd07458149a]