postgrespro.git / summary / log / commit / refs

commit    947a35014fdc2ec74cbf06c7dbac6eea6fae90c6
Author:   Noah Misch <noah@leadboat.com>
Date:     Sat Apr 13 18:09:27 2019 +0000

    When Perl "kill(9, ...)" fails, try "pg_ctl kill".
    
    Per buildfarm member jacana, the former fails under msys Perl 5.8.8.
    Back-patch to 9.6, like the code in question.
    
    Discussion: https://postgr.es/m/GrdLgAdUK9FdyZg8VIcTDKVOkys122ZINEb3CjjoySfGj2KyPiMKTh1zqtRp0TAD7FJ27G-OBB3eplxIB5GhcQH5o8zzGZfp0MuJaXJxVxk=@yesql.se


 src/test/perl/PostgresNode.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index f6570639e0..61d78ad4c0 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -789,7 +789,9 @@ sub kill9
 	my $name = $self->name;
 	return unless defined $self->{_pid};
 	print "### Killing node \"$name\" using signal 9\n";
-	kill(9, $self->{_pid}) or BAIL_OUT("kill(9, $self->{_pid}) failed");
+	# kill(9, ...) fails under msys Perl 5.8.8, so fall back on pg_ctl.
+	kill(9, $self->{_pid})
+	  or TestLib::system_or_bail('pg_ctl', 'kill', 'KILL', $self->{_pid});
 	$self->{_pid} = undef;
 	return;
 }


[parent: 5f1433ac5e7f]