postgres.git / summary / log / commit / refs

commit    9733eb9e8df78f97c2f90abb7373d7bed4c5a4b3
Author:   Melanie Plageman <melanieplageman@gmail.com>
Date:     Tue Sep 22 22:27:25 2026 +0000

    Avoid replay cleanup locks for freeze-only and VM-only records
    
    6dbb490261a combined pruning and freezing in a single WAL record but
    unconditionally requested a cleanup lock during replay. Prior to version
    17, freeze-only records were replayed under an ordinary exclusive lock.
    
    1252a4ee286 subsequently folded visibility map updates into the same
    records, extending the unnecessary cleanup-lock requirement to VM-only
    updates starting in version 19.
    
    Request a cleanup lock in redo only when the record actually prunes.
    Freezing and visibility updates do not move or remove tuple storage, so
    they need not wait for other buffer pins to be released. This avoids
    unnecessary replay delays and cancellation of standby queries holding
    buffer pins.
    
    The fix is the same for all versions, though it addresses two oversights
    in master/19 and one in 18/17.
    
    Reported-by: Satyanarayana Narlapuram <satyanarlapuram@gmail.com>
    Reported-by: Andrey Borodin <x4mmm@yandex-team.ru>
    Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
    Discussion: https://postgr.es/m/85b6968b-49f2-4243-86a6-9b4116e6439b@iki.fi
    Discussion: https://postgr.es/m/CAHg+QDf3NcB3vOAqQ5EFcV5DYYUZ9snCSJAU-x1JDbtcjK3eBQ@mail.gmail.com
    Discussion: https://postgr.es/m/F9BF304E-1298-481C-829A-B4E10AED025A@yandex-team.ru
    Backpatch-through: 17


 src/backend/access/heap/pruneheap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/access/heap/pruneheap.c b/src/backend/access/heap/pruneheap.c
index a36c6b842e8..01ef336fe43 100644
--- a/src/backend/access/heap/pruneheap.c
+++ b/src/backend/access/heap/pruneheap.c
@@ -836,7 +836,7 @@ heap_page_prune_and_freeze(Relation relation, Buffer buffer,
 
 			log_heap_prune_and_freeze(relation, buffer,
 									  conflict_xid,
-									  true, reason,
+									  do_prune, reason,
 									  prstate.frozen, prstate.nfrozen,
 									  prstate.redirected, prstate.nredirected,
 									  prstate.nowdead, prstate.ndead,


[parent: b28c6c443e40]