postgres.git / summary / log / commit / refs

commit    973caf7291c119ac1679734ae23721bbbb7df0da
Author:   Jeff Davis <jdavis@postgresql.org>
Date:     Wed Jul 16 16:57:07 2025 +0000
First released in: 18.0

    pg_dumpall: Skip global objects with --statistics-only or --no-schema.
    
    Previously, pg_dumpall would still dump global objects such as roles
    and tablespaces even when --statistics-only or --no-schema was specified.
    Since these global objects are treated as schema-level data, they should
    be skipped in these cases.
    
    This commit fixes the issue by ensuring that global objects are not
    dumped when either --statistics-only or --no-schema is used.
    
    Author: Fujii Masao <masao.fujii@oss.nttdata.com>
    Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
    Discussion: https://postgr.es/m/08129593-6f3c-4fb9-94b7-5aa2eefb99b0@oss.nttdata.com
    Backpatch-through: 18


src/bin/pg_dump/pg_dumpall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c index 3cbcad65c5f..100317b1aa9 100644 --- a/src/bin/pg_dump/pg_dumpall.c +++ b/src/bin/pg_dump/pg_dumpall.c @@ -632,7 +632,7 @@ main(int argc, char *argv[]) fprintf(OPF, "SET escape_string_warning = off;\n"); fprintf(OPF, "\n"); - if (!data_only) + if (!data_only && !statistics_only && !no_schema) { /* * If asked to --clean, do that first. We can avoid detailed [parent: 40c66f8585bc]