postgres.git / summary / log / commit / refs

commit    9ca99cda21a7eeb4bd975c811e7bcc6584255e1b
Author:   Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date:     Tue May 19 08:30:00 2009 +0000
First released in: 8.4.0, 8.1.18, 8.2.14, 8.3.8

    Update relpages and reltuples estimates in stand-alone ANALYZE, even if
    there's no analyzable attributes or indexes. We also used to report 0 live
    and dead tuples for such tables, which messed with autovacuum threshold
    calculations.
    
    This fixes bug #4812 reported by George Su. Backpatch back to 8.1.


 src/backend/commands/analyze.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c
index 6285a578889..5c5eb0444dd 100644
--- a/src/backend/commands/analyze.c
+++ b/src/backend/commands/analyze.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.136 2009/05/05 18:02:11 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.137 2009/05/19 08:30:00 heikki Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -363,19 +363,10 @@ analyze_rel(Oid relid, VacuumStmt *vacstmt,
 	}
 
 	/*
-	 * Quit if no analyzable columns
+	 * Quit if no analyzable columns and no pg_class update needed.
 	 */
-	if (attr_cnt <= 0 && !analyzableindex)
-	{
-		/*
-		 * We report that the table is empty; this is just so that the
-		 * autovacuum code doesn't go nuts trying to get stats about a
-		 * zero-column table.
-		 */
-		if (update_reltuples)
-			pgstat_report_analyze(onerel, 0, 0);
+	if (attr_cnt <= 0 && !analyzableindex && !update_reltuples)
 		goto cleanup;
-	}
 
 	/*
 	 * Determine how many rows we need to sample, using the worst case from


[parent: 7280fab71738]