postgres.git / summary / log / commit / refs

commit    9de74ca706f64ff44bac7ba54209dd1a6eabdb45
Author:   Michael Paquier <michael@paquier.xyz>
Date:     Thu Sep 07 05:12:31 2023 +0000

    pg_basebackup: Generate valid temporary slot names under PQbackendPID()
    
    pgbouncer can cause PQbackendPID() to return negative values due to it
    filling be_pid with random bytes (even these days pid_max can only be
    set up to 2^22 on 64b machines on Linux, for example, so this cannot
    happen with normal PID numbers).  When this happens, pg_basebackup may
    generate a temporary slot name that may not be accepted by the parser,
    leading to spurious failures, like:
    pg_basebackup: error: could not send replication command
    ERROR:  replication slot name "pg_basebackup_-1201966863" contains
    invalid character
    
    This commit fixes that problem by formatting the result from
    PQbackendPID() as an unsigned integer when creating the temporary
    replication slot name, so as the invalid character is gone and the
    command can be parsed.
    
    Author: Jelte Fennema
    Reviewed-by: Daniel Gustafsson, Nishant Sharma
    Discussion: https://postgr.es/m/CAGECzQQOGvYfp8ziF4fWQ_o8s2K7ppaoWBQnTmdakn3s-4Z=5g@mail.gmail.com
    Backpatch-through: 11


 src/bin/pg_basebackup/pg_basebackup.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
index 10350c97d0d..a0734098269 100644
--- a/src/bin/pg_basebackup/pg_basebackup.c
+++ b/src/bin/pg_basebackup/pg_basebackup.c
@@ -652,7 +652,8 @@ StartLogStreamer(char *startpos, uint32 timeline, char *sysidentifier)
 	 * Create replication slot if requested
 	 */
 	if (temp_replication_slot && !replication_slot)
-		replication_slot = psprintf("pg_basebackup_%d", (int) PQbackendPID(param->bgconn));
+		replication_slot = psprintf("pg_basebackup_%u",
+									(unsigned int) PQbackendPID(param->bgconn));
 	if (temp_replication_slot || create_slot)
 	{
 		if (!CreateReplicationSlot(param->bgconn, replication_slot, NULL,


[parent: a8e897e8beaf]