postgrespro.git / summary / log / commit / refs

commit    9ee7414ed0435d8946d040eb523824f2d71e2418
Author:   Peter Geoghegan <pg@bowt.ie>
Date:     Mon Apr 29 21:14:38 2019 +0000

    Remove obsolete _bt_insert_parent() comment.
    
    Remove a comment that refers to a coding practice that was fully removed
    by commit a8b8f4db, which introduced MarkBufferDirty().  It looks like
    the comment was even obsolete before then, since it concerns
    write-ordering dependencies with synchronous buffer writes.


 src/backend/access/nbtree/nbtinsert.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/access/nbtree/nbtinsert.c b/src/backend/access/nbtree/nbtinsert.c
index 49a94d8cd9..9c82ca6597 100644
--- a/src/backend/access/nbtree/nbtinsert.c
+++ b/src/backend/access/nbtree/nbtinsert.c
@@ -1786,7 +1786,6 @@ _bt_insert_parent(Relation rel,
 		 */
 		_bt_relbuf(rel, rbuf);
 
-		/* Check for error only after writing children */
 		if (pbuf == InvalidBuffer)
 			elog(ERROR, "failed to re-find parent key in index \"%s\" for split pages %u/%u",
 				 RelationGetRelationName(rel), bknum, rbknum);


[parent: a1a789eb5ac8]