postgrespro.git / summary / log / commit / refs

commit    9f2c4edec2e2182a2fef8495efdaf90a65d64e6c
Author:   David Rowley <drowley@postgresql.org>
Date:     Wed Apr 22 10:12:19 2020 +0000

    Remove bogus Assert in foreign key cloning code
    
    This Assert was trying to ensure that the number of columns in the foreign
    key being cloned was the same number of attributes in the parentRel.  Of
    course, it's perfectly valid to have columns in the table which are not
    part of the foreign key constraint. It appears that this Assert was
    misunderstanding that.
    
    Reported-by: Rajkumar Raghuwanshi
    Reviewed-by: amul sul
    Discussion: https://postgr.es/m/CAKcux6=z1dtiWw5BOpqDx-U6KTiq+zD0Y2m810zUtWL+giVXWA@mail.gmail.com


 src/backend/commands/tablecmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 794ff30fac..5745cd648a 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -9043,7 +9043,7 @@ CloneFkReferenced(Relation parentRel, Relation partitionRel)
 								   conpfeqop,
 								   conppeqop,
 								   conffeqop);
-		Assert(numfks == attmap->maplen);
+
 		for (int i = 0; i < numfks; i++)
 			mapped_confkey[i] = attmap->attnums[confkey[i] - 1];
 


[parent: aaf069aa3452]