postgres.git / summary / log / commit / refs

commit    a1e61badf97bc446053145ba40de6db835678ce3
Author:   Tom Lane <tgl@sss.pgh.pa.us>
Date:     Sat Jun 29 14:30:08 2019 +0000
First released in: 12.0

    Disallow user-created replication origins named "pg_xxx".
    
    Since we generate such names internally, it seems like a good idea
    to have a policy of disallowing them for user use, as we do for many
    other object types.  Otherwise attempts to use them will randomly
    fail due to collisions with internally-generated names.
    
    Discussion: https://postgr.es/m/3606.1561747369@sss.pgh.pa.us


 src/backend/replication/logical/origin.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/backend/replication/logical/origin.c b/src/backend/replication/logical/origin.c
index ff4d54d6edd..5bb804cece1 100644
--- a/src/backend/replication/logical/origin.c
+++ b/src/backend/replication/logical/origin.c
@@ -78,6 +78,7 @@
 #include "access/table.h"
 #include "access/xact.h"
 
+#include "catalog/catalog.h"
 #include "catalog/indexing.h"
 #include "nodes/execnodes.h"
 
@@ -1228,6 +1229,15 @@ pg_replication_origin_create(PG_FUNCTION_ARGS)
 	replorigin_check_prerequisites(false, false);
 
 	name = text_to_cstring((text *) DatumGetPointer(PG_GETARG_DATUM(0)));
+
+	/* Replication origins "pg_xxx" are reserved for internal use */
+	if (IsReservedName(name))
+		ereport(ERROR,
+				(errcode(ERRCODE_RESERVED_NAME),
+				 errmsg("replication origin name \"%s\" is reserved",
+						name),
+				 errdetail("Origin names starting with \"pg_\" are reserved.")));
+
 	roident = replorigin_create(name);
 
 	pfree(name);


[parent: c0faa727507e]