pgpool2.git / summary / log / commit / refs

commit    a33d835f807ee2bca25e621fc88180a99e83140f
Author:   Muhammad Usama <m.usama@gmail.com>
Date:     Thu Oct 03 15:33:22 2019 +0000

    Fix for Coverity warnings in pool_auth


 src/auth/auth-scram.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/auth/auth-scram.c b/src/auth/auth-scram.c
index 953c34138..3b0b3cd6b 100644
--- a/src/auth/auth-scram.c
+++ b/src/auth/auth-scram.c
@@ -502,6 +502,9 @@ scram_verify_plain_password(const char *username, const char *password,
 	{
 		ereport(LOG,
 				(errmsg("invalid SCRAM verifier for user \"%s\"", username)));
+
+		pfree(encoded_salt);
+		pfree(salt);
 		return false;
 	}
 
@@ -514,6 +517,7 @@ scram_verify_plain_password(const char *username, const char *password,
 	 * user-supplied password.
 	 */
 	pfree(encoded_salt);
+	pfree(salt);
 	return memcmp(computed_key, server_key, SCRAM_KEY_LEN) == 0;
 }
 
@@ -592,6 +596,8 @@ parse_scram_verifier(const char *verifier, int *iterations, char **salt,
 	if (decoded_len != SCRAM_KEY_LEN)
 		goto invalid_verifier;
 
+	pfree(v);
+
 	return true;
 
 invalid_verifier:


[parent: 33f17e75e640]