postgres.git / summary / log / commit / refs

commit    a775406ec439bc585a17f8edffd47641390d6e5a
Author:   Magnus Hagander <magnus@hagander.net>
Date:     Sun Oct 30 13:10:39 2016 +0000

    Fix memory leak in tar file padding
    
    Spotted by Coverity, patch by Michael Paquier


 src/bin/pg_basebackup/walmethods.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c
index 1ecc23c2560..40c8a5c697c 100644
--- a/src/bin/pg_basebackup/walmethods.c
+++ b/src/bin/pg_basebackup/walmethods.c
@@ -442,9 +442,14 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)
 		ssize_t		r = tar_write(f, zerobuf, bytestowrite);
 
 		if (r < 0)
+		{
+			pg_free(zerobuf);
 			return false;
+		}
 		bytesleft -= r;
 	}
+
+	pg_free(zerobuf);
 	return true;
 }
 


[parent: d4b5d4caddb7]